remove raycaster.recursive, update raycaster docs #3980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
force-pushed
the
raycastrecursive
branch
from
bcd6ef5 to
9bf5bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
raycaster.recursivedoesn't really do anything since raycaster only targets objects set withsetObject3D, not the general entity scenegraph. Removing it to remove confusion, and continue to prescribe that all raycastable entities are explicitly specified via.objects.We pass
truefor the recursive flag to the actual three.js raycast call so children ofgetObject3D('mesh')for example will be raycastable.