Skip to content

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Dec 6, 2018

Description:

When working with Inspector, there's friction in refreshing the scene + opening the Inspector + searching the entity / selecting the entity + repeat.

Changes proposed:

  • Add optional ?inspector={elementId} URL parameter that automatically opens the Inspector and focuses on the passed-in entity (if any). Then if you are working in an Inspector workflow (e.g., tweaking an entity), just keep the URL parameter there and refresh.
  • Add Entity.inspect() method to easily open/focus any entity in Inspector from DevTools console.

If merged, matching Inspector changes will follow.

@ngokevin ngokevin force-pushed the inspect branch 3 times, most recently from b43bbb8 to 58e7b79 Compare December 9, 2018 07:38
@ngokevin ngokevin merged commit 57778b8 into aframevr:master Dec 10, 2018
@dmarcos
Copy link
Member

dmarcos commented Dec 10, 2018

Should have waited for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants