Skip to content

Conversation

@neoncrumpet
Copy link

Description:

The * in the regex was catching the UA of the Chrome Webview on iOS.

Changes proposed:

  • Check for an underscore after the version number

** Notes **

There might be a better regex to accomplish this.

@neoncrumpet
Copy link
Author

This should fix #3846 and #3788

Copy link
Member

@dmarcos dmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Super apreciated. Congrats on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants