Skip to content

Conversation

@mqp
Copy link
Contributor

@mqp mqp commented Jun 16, 2018

THREE.Object3D.getWorldPosition already internally calls updateMatrixWorld in order to always produce an up-to-date position, so we don't want to call it ourselves first -- that's just doing the work twice.

@mqp
Copy link
Contributor Author

mqp commented Jun 16, 2018

By the way, I would be interested to understand why raycaster.checkIntersections calls setTimeout(updateLine) at the end. Why can't it just call updateLine directly? Alternatively, can drawLine happen in the next tick, instead of in a separate timeout? I ask because the raycaster code is fairly performance-sensitive for our team and setTimeout is relatively slow.

@ngokevin ngokevin merged commit 12872cc into aframevr:master Jun 16, 2018
@ngokevin
Copy link
Member

Not sure, should have left a comment back then. You can try removing it or moving to a tock.

@donmccurdy donmccurdy added this to the 0.9.0 milestone Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants