remove garbage and bubbling from tracked-controls #3589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
May 19, 2018
| this.axis.push(controllerAxes[i]); | ||
| } | ||
| this.el.emit('axismove', this.axisMoveEventDetail); | ||
| this.el.emit(EVENTS.AXISMOVE, this.axisMoveEventDetail, false); |
Member
There was a problem hiding this comment.
I’m ok with the PR but I believe these strings should be allocated on stack and not on the heap so no subjects for GC
Member
Author
There was a problem hiding this comment.
I read strings get collected. But this PR also removes the string concatenations which do allocate and are messy anyways, constants are cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Objects and strings were being created on every button touch, press, and up.
Changes proposed: