Skip to content

Conversation

@wrjanan
Copy link
Contributor

@wrjanan wrjanan commented May 14, 2018

Description:
simple methods to implement on videosphere

Changes proposed:

  • how to set current time of video in videosphere
  • how to play video

@wrjanan
Copy link
Contributor Author

wrjanan commented May 14, 2018

can update more methods should this be useful

@ngokevin
Copy link
Member

This is covered at https://aframe.io/docs/0.8.0/components/material.html#video-textures, I would add a link to there.

@ngokevin
Copy link
Member

Hey @wrjanan, can you update the PR to just add a link to above? ../components/material.html#video-textures? Thanks!

@wrjanan
Copy link
Contributor Author

wrjanan commented Jul 4, 2018

Updated the PR to add the link, am uncertain if the link is to the right location.

Is it a common issue in github where we are unable to test the linking accuracy since the preview of links are stored in a hosting URL?

Thank you @ngokevin for the learning experience !

@ngokevin ngokevin merged commit c0d279f into aframevr:master Jul 4, 2018
@ngokevin
Copy link
Member

ngokevin commented Jul 4, 2018

If you view it in GitHub, or npm run docs, you can test the link. It looks good!

@wrjanan wrjanan deleted the patch-2 branch July 5, 2018 03:44
@donmccurdy donmccurdy added this to the 0.9.0 milestone Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants