Skip to content

remove default components #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2018
Merged

remove default components #3490

merged 1 commit into from
Mar 24, 2018

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Mar 23, 2018 •
edited
Loading

Description:

Save 4 component initializations per entity.

Allows for setting with object3D API on creation without the component overriding with 0/0/0:

var entity = document.createElement('a-entity');
entity.object3D.position.set(1, 2, 3);
scene.appendChild(entity);

Changes proposed:

  • Save 4 component initializations per entity.
  • Don't need pos/rot/scale/vis components initializations by default if not defined.
  • Removes a bunch of code in the component lifecycle that checks for default component

@ngokevin ngokevin force-pushed the nodefcomp branch 2 times, most recently from 927afc9 to 9270d5f Compare March 23, 2018 05:03
@ngokevin ngokevin changed the title [WIP] remove default components remove default components Mar 23, 2018
@ngokevin ngokevin mentioned this pull request Mar 23, 2018
Closed
dmarcos
dmarcos reviewed Mar 23, 2018
View reviewed changes
src/core/a-entity.js Outdated
// If cached value exists, return partial component data.
var component = this.components[attr];
if (component) { return component.attrValue; }
// if (OBJECT3D_PROPERTIES.indexOf(attr) !== -1) { return this.getAttribute(attr); }
Copy link
Member

@dmarcos dmarcos Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Member Author

@ngokevin ngokevin Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@dmarcos dmarcos merged commit 0ba6c34 into aframevr:master Mar 24, 2018
@dmarcos dmarcos mentioned this pull request Mar 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmarcos dmarcos dmarcos left review comments

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ngokevin @dmarcos