Improve function names in debugger call stacks #3310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
reviewed
Dec 19, 2017
src/core/a-register-element.js
Outdated
| } | ||
|
|
||
| // Give all functions their proper name. | ||
| for (const propName of Object.getOwnPropertyNames(newObj.prototype)) { |
ngokevin
reviewed
Dec 19, 2017
| document.body.appendChild(document.createElement('a-test-entity-2')); | ||
| }); | ||
|
|
||
| test.only('Names functions correctly', function (done) { |
There was a problem hiding this comment.
remove .only, uncapitalize test name
dmarcos
reviewed
Dec 19, 2017
src/core/a-register-element.js
Outdated
| // Give all functions their proper name. | ||
| for (var propName of Object.getOwnPropertyNames(newObj.prototype)) { | ||
| var propVal = newObj.prototype[propName]; | ||
| if (propVal && typeof propVal === 'function') { |
There was a problem hiding this comment.
Is checking for if ( typeof propVal === 'function') sufficient?
There was a problem hiding this comment.
Ah, yes. Will fix.
|
There's a |
|
The |
|
You're right! The Github PR conversation is not the best to keep track of updates. |
|
Thanks! 👍 |
|
Sweet, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently most functions in an A-Frame call stack are named "value" due to the way elements are defined and registered.
This change makes use of the displayName property on functions to improve call stack readability.
Before:
After:
Changes proposed: