optimize event emit (fixes #3294) #3308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Emit was potentially creating object in three spots:
data = {bubbles: !!bubbles, detail: detail}data = data || {};data.detail = data.detail || {};This PR makes it to reuse the same object on each emit, except if
extraDatais provided, in which that customizes the event and we need a separate object.There is no worry of cross-contamination. The
CustomEventdata parameter will pass the object properties along to the event object, but the data parameter objects themselves aren't exposed.I removed the indirection to the
utils.fireEvent(unused, undocumented). It seems its purpose was to create objects if necessary which is no longer needed. It also addeddetail.targetwhich is not needed because the browser natively hasevent.targetandevent.currentTarget. Also made it confusing when event detail objects are reused at application level, theevent.detail.targetwas often incorrect in my experience through contamination.Changes proposed:
.emit()except in the case ofextraData.nodereadyevent, just passundefined.