optimize aframe.utils.diff #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dmarcos merged 1 commit into aframevr:master from ngokevin:optimizediff

Dec 7, 2017

Member

ngokevin commented Dec 6, 2017

Description:

Changes proposed:

Remove creation objects, arrays, functions, closures.
Allow specify targetObject to be the return object versus creating an objevt.


          optimize aframe.utils.diff

ee7f7cc

ngokevin added the needs review label

Member Author

ngokevin commented Dec 7, 2017

r?

dmarcos approved these changes

View reviewed changes

dmarcos merged commit ef5a398 into aframevr:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels