-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
make the example 360 video page redirect to example Glitch #3210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, I'd focus on placing this within the documentation (FAQ, material page, videosphere page, future video guide) and move away from expecting the |
|
The primary usage I saw was the sidebar link for 360 video, and rather than changing all of those links to point at Glitch directly (which is not versioned, so potential issues if we change things later), I changed the target to be a stub. That also allows previous links to the destination from external sites or personal bookmarks to be redirected to the new Glitch. Is there a list of all the other places to change? Happy to change those to direct Glitch links where it makes sense |
|
As an example of the kind of concerns I have:
|
|
The site sidebar link can be changed to your Glitch |
|
ok - anywhere else? |
|
There is some confusion here. What we should do is: Add the example to the documentation as noted here: https://github.com/aframevr/aframe/blob/master/CONTRIBUTING.md#add-glitch-examples-to-documentation The examples don't need to be touched as we don't want to use them for developer reference as much as documentation and Glitches. I was talking about the A-Frame homepage sidebar, we can update the link to the source code. |
|
ok, so yes there is some confusion. isn't the A-Frame homepage sidebar this? (when you click it, currently goes to the boilerplate 360-video example not its source; this changes to go to glitch not its source, but could easily go to its source if that is what you wanted) and you'd simply like to revert this, leaving the previous example unchanged but no longer linked? |
|
I did specifically ask about the existing documentation but no answer, only about site sidebar: |
|
Okay to change the link in |
|
got it, thanks! The branch for this PR now has just the docs example link change. Did you want to reopen this one, or have me do another PR? The homepage link is in a different repo I presume, will find it and address there. |
Per discussion on #2830, this PR replaces the previous example of 360 video in the repo to redirect to an example Glitch. The example takes advantage of recently-merged #3176 to show how a video can be specified as HLS and MP4.