Skip to content

Conversation

@machenmusik
Copy link
Contributor

Per discussion on #2830, this PR replaces the previous example of 360 video in the repo to redirect to an example Glitch. The example takes advantage of recently-merged #3176 to show how a video can be specified as HLS and MP4.

@ngokevin
Copy link
Member

Thanks, I'd focus on placing this within the documentation (FAQ, material page, videosphere page, future video guide) and move away from expecting the examples/ directory to be the official place. Perhaps an HTML comment in the existing videosphere page, but we keep the examples/ directory mainly for testing core features.

https://github.com/aframevr/aframe/blob/master/CONTRIBUTING.md#add-glitch-examples-to-documentation

@machenmusik
Copy link
Contributor Author

The primary usage I saw was the sidebar link for 360 video, and rather than changing all of those links to point at Glitch directly (which is not versioned, so potential issues if we change things later), I changed the target to be a stub. That also allows previous links to the destination from external sites or personal bookmarks to be redirected to the new Glitch.

Is there a list of all the other places to change? Happy to change those to direct Glitch links where it makes sense

@machenmusik
Copy link
Contributor Author

As an example of the kind of concerns I have:

  • The docs/primitive/videosphere.md page links to the edit page for a Glitch example. It is unclear to me whether this example link should be changed or not.

  • The Glitch example, when you go and look at it, is referencing an older version of A-Frame (0.6.1). If there were breaking changes between 0.6.1 and now, the same Glitch would be stuck failing for one or the other, as the Glitch itself is not versioned.

  • The Glitch example, when you go and look at it, has been edited (probably unintentionally) so that it is rotated 80 degrees instead of 180 degrees. We need a way to make the Glitch viewable, but require remix to edit.

@ngokevin
Copy link
Member

ngokevin commented Nov 1, 2017

The site sidebar link can be changed to your Glitch

@machenmusik
Copy link
Contributor Author

ok - anywhere else?

@ngokevin
Copy link
Member

ngokevin commented Nov 2, 2017

There is some confusion here. What we should do is:

Add the example to the documentation as noted here: https://github.com/aframevr/aframe/blob/master/CONTRIBUTING.md#add-glitch-examples-to-documentation

The examples don't need to be touched as we don't want to use them for developer reference as much as documentation and Glitches. I was talking about the A-Frame homepage sidebar, we can update the link to the source code.

@ngokevin ngokevin closed this Nov 2, 2017
@machenmusik
Copy link
Contributor Author

ok, so yes there is some confusion.

isn't the A-Frame homepage sidebar this? (when you click it, currently goes to the boilerplate 360-video example not its source; this changes to go to glitch not its source, but could easily go to its source if that is what you wanted)
7309eca

and you'd simply like to revert this, leaving the previous example unchanged but no longer linked?
aeb4f81

@machenmusik
Copy link
Contributor Author

I did specifically ask about the existing documentation but no answer, only about site sidebar:

The docs/primitive/videosphere.md page links to the edit page for a Glitch example. It is unclear to me whether this example link should be changed or not.

@ngokevin
Copy link
Member

ngokevin commented Nov 2, 2017

Okay to change the link in a-videosphere and 7309eca is not the homepage (http://aframe.io/). If we can keep threads concise, it'd be easier to not miss things.

@machenmusik
Copy link
Contributor Author

got it, thanks!

The branch for this PR now has just the docs example link change. Did you want to reopen this one, or have me do another PR?

The homepage link is in a different repo I presume, will find it and address there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants