Remove everGotGamepadEvent flag and gamepadconnected / gamepaddisconnected handlers (fix #2769) #3189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
force-pushed
the
noEverGotGamepad
branch
from
1281075 to
d2a622f
Compare
dmarcos
changed the title
dmarcos
force-pushed
the
noEverGotGamepad
branch
from
d2a622f to
194cda6
Compare
|
@dmarcos it works! :) |
|
nice catch |
|
There is a this.everGotGamepadEvent variable in gearvr-controls.js that seems unused, you may want to remove it too. |
cvan
reviewed
Oct 26, 2017
| }, | ||
|
|
||
| onGamepadConnectionEvent: function (evt) { | ||
| this.everGotGamepadEvent = true; |
There was a problem hiding this comment.
yeah, per @vincentfretin's comment, there are a few more:
src/components/gearvr-controls.js
59: this.everGotGamepadEvent = false;
tests/components/daydream-controls.test.js
198: // Reset everGotGamepadEvent so we don't think we've looked before.
199: delete component.everGotGamepadEvent;
tests/components/gearvr-controls.test.js
211: // Reset everGotGamepadEvent so we don't think we've looked before.
212: delete component.everGotGamepadEvent;
tests/components/oculus-touch-controls.test.js
166: // Reset everGotGamepadEvent so we don't think we've looked before.
167: delete component.everGotGamepadEvent;
tests/components/vive-controls.test.js
194: // Reset everGotGamepadEvent to mock not looked before.
195: delete component.everGotGamepadEvent;
tests/components/windows-motion-controls.test.js
533: // Reset everGotGamepadEvent so we don't think we've looked before.
534: delete component.everGotGamepadEvent;
…ected handlers (fix aframevr#2769) We moved away from using gamepadconnected / gamepaddisconnected events from the rest of the controls. We forgot to remove the handlers from daydream-controls. This was causing problems where sometimes gamepadconnected was fired before tracked-controls had a chance to update controllers and emit controllersupdated. The flag everGotGamepadEvent was set to true leaving onControllersUpdate without effect after tracked-controls had updated the controllers list. The timing of the gamepadconnected event seems to have changed in Chrome Daydream and this problem had not manifested before.
dmarcos
force-pushed
the
noEverGotGamepad
branch
from
194cda6 to
82fda79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.