Skip to content

Bump THREE to r87 #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2017
Merged

Bump THREE to r87 #2994

merged 1 commit into from
Aug 25, 2017

Conversation

@dmarcos
Copy link
Member

@dmarcos dmarcos commented Aug 24, 2017

No description provided.

@dmarcos
Copy link
Member Author

dmarcos commented Aug 24, 2017

@donmccurdy Bumping THREE to r87. It seems that GLTF2Loader has been renamed to GLTFLoader

donmccurdy
donmccurdy reviewed Aug 24, 2017
View reviewed changes
Copy link
Member

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to edit the comment here and usage in gltf-model and tests.

@donmccurdy
Copy link
Member

donmccurdy commented Aug 24, 2017

Does r87 force us to change any other VREffect usage?

@dmarcos
Copy link
Member Author

dmarcos commented Aug 24, 2017 •
edited
Loading

I don't believe so. I will do a sanity check in VR to make sure it works.

@dmarcos
Copy link
Member Author

dmarcos commented Aug 25, 2017

Tried on Gear VR and everything seems to work.

@dmarcos dmarcos merged commit 61fb844 into aframevr:master Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@donmccurdy donmccurdy donmccurdy left review comments

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmarcos @donmccurdy