fix missing detail property in a-scene onVRPresentChange #2920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which platform/browser? Sure it's not on the event iself? https://w3c.github.io/webvr/spec/1.1/#interface-vrdisplayevent |
|
ah, right. I forgot I ran into this on webvr-ui as well. When using the WebVR API it is directly on Pull request updated to look for either. |
|
this fixes issue #2849 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
onVRPresentChangethrows error thatevt.displayis undefined. Thedisplayproperty exists underCustomEvent#detailproperty and not directly onCustomEvent.Changes proposed:
isPresentingatevt.detail.display.isPresenting