Skip to content

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Jul 31, 2017

Description:

I ran into a bug where updating geometry component using same object where the data did not change was re-creating the geometry. If the data does not change, then the update handler should not run.

Changes proposed:

  • Still do component data comparison even if skipTypeChecking is enabled.
  • Give selector/selectorAll property types null default value. Because the string was getting resolved to null, the deepEqual comparison for components was false (e.g., oldData.geometry.mergeTo == '') vs. oldData.geometry.mergeTo == null). This can cause components to needlessly update.

@dmarcos dmarcos merged commit b775821 into aframevr:master Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants