Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions src/core/scene/a-scene.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,22 @@ module.exports.AScene = registerElement('a-scene', {
this.onVRPresentChangeBound = bind(this.onVRPresentChange, this);
window.addEventListener('vrdisplaypresentchange', this.onVRPresentChangeBound);

// bind functions
this.enterVRBound = function () { self.enterVR(); };
this.exitVRBound = function () { self.exitVR(); };
this.exitVRTrueBound = function () { self.exitVR(true); };

// Enter VR on `vrdisplayactivate` (e.g. putting on Rift headset).
window.addEventListener('vrdisplayactivate', function () { self.enterVR(); });
window.addEventListener('vrdisplayactivate', this.enterVRBound);

// Exit VR on `vrdisplaydeactivate` (e.g. taking off Rift headset).
window.addEventListener('vrdisplaydeactivate', function () { self.exitVR(); });
window.addEventListener('vrdisplaydeactivate', this.exitVRBound);

// Enter VR on `vrdisplayconnect` (e.g. plugging on Rift headset).
window.addEventListener('vrdisplayconnect', this.enterVRBound);

// Exit VR on `vrdisplaydisconnect` (e.g. unplugging Rift headset).
window.addEventListener('vrdisplaydisconnect', this.exitVRTrueBound);
},
writable: window.debug
},
Expand Down Expand Up @@ -163,6 +174,10 @@ module.exports.AScene = registerElement('a-scene', {
scenes.splice(sceneIndex, 1);

window.removeEventListener('vrdisplaypresentchange', this.onVRPresentChangeBound);
window.removeEventListener('vrdisplayactivate', this.enterVRBound);
window.removeEventListener('vrdisplaydeactivate', this.exitVRBound);
window.removeEventListener('vrdisplayconnect', this.enterVRBound);
window.removeEventListener('vrdisplaydisconnect', this.exitVRTrueBound);
}
},

Expand Down Expand Up @@ -247,7 +262,8 @@ module.exports.AScene = registerElement('a-scene', {
throw new Error('Failed to enter VR mode (`requestPresent`).');
}
}
}
},
writable: window.debug
},
/**
* Call `exitPresent` if WebVR or WebVR polyfill.
Expand Down Expand Up @@ -296,7 +312,8 @@ module.exports.AScene = registerElement('a-scene', {
throw new Error('Failed to exit VR mode (`exitPresent`).');
}
}
}
},
writable: window.debug
},

/**
Expand Down
30 changes: 30 additions & 0 deletions tests/core/scene/a-scene.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,36 @@ suite('a-scene (without renderer)', function () {
});
});

suite('vrdisplayconnect', function () {
test('tells A-Frame about entering VR when the headset is connected', function (done) {
var event;
var sceneEl = this.el;
var enterVRStub = this.sinon.stub(sceneEl, 'enterVR');
sceneEl.effect = {requestPresent: function () { return Promise.resolve(); }};
event = new CustomEvent('vrdisplayconnect');
window.dispatchEvent(event);
process.nextTick(function () {
assert.ok(enterVRStub.called);
done();
});
});
});

suite('vrdisplaydisconnect', function () {
test('tells A-Frame about entering VR when the headset is disconnected', function (done) {
var event;
var sceneEl = this.el;
var exitVRStub = this.sinon.stub(sceneEl, 'exitVR');
sceneEl.effect = {requestPresent: function () { return Promise.resolve(); }};
event = new CustomEvent('vrdisplaydisconnect');
window.dispatchEvent(event);
process.nextTick(function () {
assert.ok(exitVRStub.calledWith(true));
done();
});
});
});

suite('vrdisplaypresentchange', function () {
test('tells A-Frame about entering VR if now presenting', function (done) {
var event;
Expand Down