oculus-touch-controls.js:347 Uncaught TypeError: Cannot read properties of undefined (reading 'trigger')

[mikemainguy]

Description:

• A-Frame Version: a-frame master
• Platform / Device: oculus quest 2
• Reproducible Code Snippet or URL: https://feather-glistening-jaw.glitch.me

Navigate to above site:

oculus-touch-controls.js:347 Uncaught TypeError: Cannot read properties of undefined (reading 'trigger')
at NewComponent.onButtonChangedV3 (oculus-touch-controls.js:347:48)
at NewComponent.onButtonChanged (oculus-touch-controls.js:316:12)
at AEntity.bound (bind.js:12:17)
at AEntity.emit (a-node.js:287:10)
at NewComponent.handleButton (tracked-controls-webxr.js:134:13)
at NewComponent.updateButtons (tracked-controls-webxr.js:115:12)
at NewComponent.tick (tracked-controls-webxr.js:81:12)
at AScene.tick (a-scene.js:696:30)
at AScene.render (a-scene.js:742:32)
at bound (bind.js:12:17)

[vincentfretin]

Probably a button is pressed before the model is loaded, we'll need to verify that this.buttonRanges exists before accessing it I guess

aframe/src/components/oculus-touch-controls.js

Line 347 in 529eee8

this.triggerEuler.copy(this.buttonRanges.trigger.min.rotation);

There is also a similar issue in #5212
If anyone having a Quest 2 have one of those issues, those are really simple changes to make your first PR.

[vincentfretin]

Oh I didn't see it was also you who reported the other one. Can you try making a PR?

[dmarcos]

PRs def welcome

[vincentfretin]

It should be fixed in #5223, if you can test @mikemainguy that would be awesome.

[vincentfretin]

@dmarcos you can close this issue now that #5223 is merged.

[dmarcos]

Thanks. Fixed by #5223

What I usually do to close issues automatically is to add the issue to the commit message. "blah blah blah (fix #5220)" I'll point it out in future reviews. Also makes writting releas notes easier.

[vincentfretin]

I used "(fix #5212 and #5220)" in the commit comment but it didn't close the second issue, maybe because of the "and"?

[dmarcos]

never tried that. I believe comma should work