renderer options maxCanvasWidth & maxCanvasHeight not respected when embedded

[s-light]

Description

the renderer options maxCanvasWidth & maxCanvasHeight are not respected when the embedded option is set.

• A-Frame Version: 1.2.0
• Platform / Device:

Name                Firefox
Version             91.0.1
Build ID            20210816143654
Distribution ID     canonical
User Agent          Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0
OS                  Linux 5.4.0-81-generic #91-Ubuntu SMP Thu Jul 15 19:09:17 UTC 2021

• Reproducible Code Snippet or URL:
  • working jsfiddle
  • broken jsfiddle

<a-scene
      stats
      embedded
      renderer="
            maxCanvasWidth: 256;
            maxCanvasHeight: 256
            "
    >
      ....
    </a-scene>

[s-light]

found the relevant code lines:

• resize is calling getCanvasSize()
• and in getCanvasSize() there is no check for the maxCanvasSize if embedded is active:

function getCanvasSize (canvasEl, embedded, maxSize, isVR) {
  if (!canvasEl.parentElement) { return {height: 0, width: 0}; }
  if (embedded) {
    return {
      height: canvasEl.parentElement.offsetHeight,
      width: canvasEl.parentElement.offsetWidth
    };
  }
  return getMaxSize(maxSize, isVR);
}

currently i have not a clear idea how to fix this..

[s-light]

fix in #4912
test case:
https://codepen.io/s-light/pen/NWgWoJm?editors=1001
and the original jsfiddle linked against the fix:
https://jsfiddle.net/s_light/1zwvmh0e/1/

[dmarcos]

Thanks! Trying to understand. What's the use case where you need to downsize the canvas in embedded mode?

[s-light]

i use the embedded mode to embed a-frame in full-size over my own html content and overlaying other html boxes over aframe.
this was the easiest mode to not first reset the full-screen styles.
and the constraints of the maxCanvas* is necessary for performance reasons on 4k laptop screens -
as i otherwise get <10fps with a very simple scene.
if i constraint the size to1200x1024 i get around ~30fps -
that means a little blurred image - but better a little blurred then slow and bumpy animations.

and maybe in future i will try and experiment with some user options to select high-quality / fast-animations mode...
(but that seems a little complicated as this is a option that is only evaluated on startup..)