-
Notifications
You must be signed in to change notification settings - Fork 212
Some code cleanup #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some code cleanup #639
Conversation
e4f3a1b to
5fe086b
Compare
edf9714 to
3602672
Compare
|
eslint errors down to 15 errors instead of 350 errors |
|
I'll fix the remaining eslint errors later then this PR should be good to merge if there is no objection. |
…add src/lib/TransformControls.js to prettierignore to not reformat this file
4438598 to
7814738
Compare
|
I fixed all remaining eslint issues, excepted those: I'll fix this one as part of the react update in #641. This is already fixed in #638 This PR is ready to be merged after #638. |
|
but we can do that in a separate PR, I created the issue #642 for this. |
f539097 to
f4caec1
Compare
f4caec1 to
10c0f33
Compare
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "printWidth": 80, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this enforce 80 character lines? If that's the case not sure if these days makes much sense. In today's displays aspect ratio vertical space is more of a premium than horizontal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All files are already using the 80 characters limit actually, so no real change here.
|
This one is ready to go? Thanks for the patience. |
|
Yes, please merge. |
Uh oh!
There was an error while loading. Please reload this page.