Adjustments for THREE r144 #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tFromObject already call update so no need to call it a second time
|
I tested the provided demo scene pretty thoroughly, was not able to get any inspector-specific issues to occur. This is great work that really fixes a lot of nagging minor issues that have plagued the inspector for some time and bring it up to date, great stuff. |
|
I made a pull request against aframe-environment-component accordingly, here. |
|
Can we separate in different PRs the adjustments for THREE r144 and the rest? |
vincentfretin
force-pushed
the
fixes-for-aframe-master
branch
from
e29c270 to
d2a6c24
Compare
Merged
|
Sure, I rebased and kept only relevant commits to the threejs upgrade. The other commits are in #638 |
|
Thank you! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to work with aframe master (tested against three r141 and not r144 because there is no updated build currently on aframe repo) and fixing some issues I found while testing, see each commit for details.