Skip to content

Conversation

@OttaviaFeletig
Copy link

¡Hola Alejandro!

Thankfully I had Raul assisting me with some Spanish terms during the review of your code ;)

Congratulations, great job! Very nice code, you really understood what it means to divide a script into several functions.

You will find more punctual suggestions in the code itself, but in general, we wanted to say that it wasn't easy to read your main.js file for 2 reasons:

  1. You could have divided the JS into different files, one per "section" of your page
  2. Templating prevents others to see where some of your function calls are. Maybe the event listeners could be added separately and not within the template. Also, I can change the function directly from the inspector and, for example, instead of filtering do whatever I want. Look at the screenshot.
    Immagine

Let us know if you need more explanations!

Cheers,
Ottavia and Raul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant