This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Fix ordering bug in SelectionPlugin#266
Merged
Merged
Conversation
aevyrie
suggested changes
Oct 4, 2023
aevyrie
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_selection_eventsandupdate_state_from_eventsnot being ordered relative to one another meant that sometimes clicks would be applied toPickSelectionone frame late, and sometimes not. This led to unreliable and sometimes broken behavior, so we fix their ordering using a.chain()call to ensurePickSelectionis always updated on the frame the pointer is released.