This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Change log level from info to debug and trace#262
Merged
Conversation
This implements aevyrie#259. Messages linked to the "Noisy" debug state are logged with `trace!()`. The rest are logged with `debug!()`. Filtering on this _could_ replace the Noisy/Normal state distinction entirely (perhaps leaving the DebugPickingMode state _only_ for hiding or showing the cursor text overlay) but I'll leave that possibility for the future. This just makes a minimal change.
aevyrie
approved these changes
Oct 4, 2023
aevyrie
left a comment
aevyrie
left a comment
Owner
There was a problem hiding this comment.
This is a much needed improvement. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #259.
Messages linked to the "Noisy" debug state are logged with
trace!(). The rest are logged withdebug!(). Filtering on this could replace the Noisy/Normal state distinction entirely (perhaps leaving the DebugPickingMode state only for hiding or showing the cursor text overlay) but I'll leave that possibility for the future. This just makes a minimal change.