This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Harmonize softplus implementations - #884
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
==========================================
+ Coverage 74.10% 74.15% +0.05%
==========================================
Files 174 174
Lines 48673 48707 +34
Branches 10373 10372 -1
==========================================
+ Hits 36067 36120 +53
+ Misses 10315 10301 -14
+ Partials 2291 2286 -5
|
brandonwillard
previously approved these changes
Apr 14, 2022
rlouf
force-pushed
the
harmonize_log1pexp
branch
4 times, most recently
from
November 24, 2022 12:51
55acfa2 to
cc33443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were slight differences between the implementations for different backends.
Cimplementation. As discussed in Beta often diverges when logodds is close to 19.0 #29 (comment), this is probably not that helpful