Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Harmonize softplus implementations - #884

Merged
rlouf merged 1 commit into
aesara-devs:mainfrom
ricardoV94:harmonize_log1pexp
Nov 24, 2022
Merged

Harmonize softplus implementations#884
rlouf merged 1 commit into
aesara-devs:mainfrom
ricardoV94:harmonize_log1pexp

Conversation

@ricardoV94

Copy link
Copy Markdown
Contributor

There were slight differences between the implementations for different backends.

@brandonwillard brandonwillard added enhancement New feature or request refactor This issue involves refactoring labels Apr 7, 2022
@codecov

codecov Bot commented Apr 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #884 (55acfa2) into main (14c394d) will increase coverage by 0.05%.
The diff coverage is 95.41%.

❗ Current head 55acfa2 differs from pull request most recent head cc33443. Consider uploading reports for the commit cc33443 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   74.10%   74.15%   +0.05%     
==========================================
  Files         174      174              
  Lines       48673    48707      +34     
  Branches    10373    10372       -1     
==========================================
+ Hits        36067    36120      +53     
+ Misses      10315    10301      -14     
+ Partials     2291     2286       -5     
Impacted Files Coverage Δ
aesara/link/jax/dispatch/scalar.py 97.40% <ø> (ø)
aesara/compile/function/types.py 79.16% <75.00%> (+0.16%) ⬆️
aesara/tensor/elemwise.py 88.07% <90.54%> (-0.52%) ⬇️
aesara/tensor/rewriting/elemwise.py 86.40% <94.44%> (+0.65%) ⬆️
aesara/scalar/basic.py 79.02% <95.16%> (+0.10%) ⬆️
aesara/compile/function/pfunc.py 84.18% <100.00%> (+1.77%) ⬆️
aesara/compile/mode.py 84.47% <100.00%> (+1.22%) ⬆️
aesara/compile/sharedvalue.py 93.75% <100.00%> (+13.26%) ⬆️
aesara/scalar/math.py 85.29% <100.00%> (+0.02%) ⬆️
aesara/scan/basic.py 84.59% <100.00%> (ø)
... and 7 more

brandonwillard
brandonwillard previously approved these changes Apr 14, 2022
@rlouf
rlouf force-pushed the harmonize_log1pexp branch 4 times, most recently from 55acfa2 to cc33443 Compare November 24, 2022 12:51
@rlouf
rlouf merged commit a7ef6db into aesara-devs:main Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request refactor This issue involves refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants