This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Add F RandomVariable#1509
Merged
brandonwillard merged 1 commit intoaesara-devs:mainfrom Sep 21, 2023
aadya940:F-Op
Merged
Conversation
Member
|
Much appreciated @aadya940! |
Contributor
Author
|
I guess the test's are failing due to an issue in sphinx. Can someone please review the code before we can merge it? |
brandonwillard
suggested changes
Sep 8, 2023
Member
brandonwillard
left a comment
There was a problem hiding this comment.
Looks like there are some formatting issues that should've been caught by pre-commit.
Member
|
I've fixed the formatting issues and squashed the commits. #1512 might need to go through before this will pass, though. |
Codecov Report
@@ Coverage Diff @@
## main #1509 +/- ##
=======================================
Coverage 74.96% 74.97%
=======================================
Files 176 176
Lines 49498 49507 +9
Branches 11986 11986
=======================================
+ Hits 37108 37117 +9
Misses 10089 10089
Partials 2301 2301
|
Member
|
@aadya940, many thanks for the contribution! |
Contributor
Author
Welcome :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1366
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commitis installed and set up.