Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Downgrade flake8 pre-commit for py37 compatibility - #1374

Merged
maresb merged 1 commit into
aesara-devs:mainfrom
maresb:fix-flake8-pre-commit
Dec 15, 2022
Merged

Downgrade flake8 pre-commit for py37 compatibility#1374
maresb merged 1 commit into
aesara-devs:mainfrom
maresb:fix-flake8-pre-commit

Conversation

@maresb

@maresb maresb commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

Closes #1373

Aesara's minimum-supported Python version is 3.7, and it's probably really convenient to develop with that version in order to avoid using incompatible language features. Then of course you want to run pre-commit, but for that you either need a higher version of Python (>=3.8.1) or a lower (<=5.0.4) version of flake8.

It seems to me like the most straightforward solution is to revert flake8 to 5.0.4 (the second-most-recent release, August) until Aesara drops support for Python 3.7.

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

brandonwillard
brandonwillard previously approved these changes Dec 15, 2022
Aesara's minimum-supported Python version is 3.7, and it's probably
really convenient to develop with that version in order to avoid using
incompatible language features. Then of course you want to run
pre-commit, but for that you either need a higher version of Python
(>=3.8.1) or a lower (<=5.0.4) version of flake8.

It seems to me like the most straightforward solution is to revert
flake8 to 5.0.4 (the second-most-recent release, August) until
Aesara drops support for Python 3.7.
@maresb

maresb commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

Rebased on main

@maresb

maresb commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

I have approval, passing checks, and the big green "Rebase and merge" button. Does that mean I'm allowed to push it? 😄

@brandonwillard

Copy link
Copy Markdown
Member

I have approval, passing checks, and the big green "Rebase and merge" button. Does that mean I'm allowed to push it? smile

Yes, of course.

@maresb
maresb merged commit e9bd026 into aesara-devs:main Dec 15, 2022
@maresb
maresb deleted the fix-flake8-pre-commit branch December 15, 2022 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid pinning a particular python executable in flake8 hook

2 participants