This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Splitting before using JAX key#1345
Merged
rlouf merged 2 commits intoaesara-devs:mainfrom Dec 13, 2022
Merged
Conversation
6 tasks
Contributor
Author
|
I ran pre-commit, should be good |
b77cf5d to
38b34b6
Compare
Contributor
Author
Member
|
Should be good to merge once the tests pass. Thanks for spotting this and fixing it! |
rlouf
approved these changes
Dec 13, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
=======================================
Coverage 74.35% 74.35%
=======================================
Files 177 177
Lines 49046 49056 +10
Branches 10379 10379
=======================================
+ Hits 36468 36478 +10
Misses 10285 10285
Partials 2293 2293
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #1344
As discussed offline with @rlouf at the moment the jax splitting logic relies on knowing the internals on the splitting and doesn't follow the JAX best practices. This PR fixes this.
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commitis installed and set up.