This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Type hint of specify_shape does not allow for None in shape#1313
Merged
rlouf merged 1 commit intoaesara-devs:mainfrom Nov 27, 2022
Merged
Type hint of specify_shape does not allow for None in shape#1313rlouf merged 1 commit intoaesara-devs:mainfrom
specify_shape does not allow for None in shape#1313rlouf merged 1 commit intoaesara-devs:mainfrom
Conversation
Member
|
Thank you for opening a PR. It looks like you need to format your code using |
fec52f2 to
bd565b6
Compare
brandonwillard
previously approved these changes
Nov 25, 2022
Member
brandonwillard
left a comment
There was a problem hiding this comment.
I just updated the formatting; this should be good to merge now. Thanks @sudarsan2k5!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
=======================================
Coverage 74.22% 74.22%
=======================================
Files 174 174
Lines 48731 48732 +1
Branches 10367 10367
=======================================
+ Hits 36170 36171 +1
Misses 10273 10273
Partials 2288 2288
|
bd565b6 to
c332705
Compare
c332705 to
dff0aca
Compare
brandonwillard
approved these changes
Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1164
Updated
specify_shapetype hint , allowed None in shapeHere are a few important guidelines and requirements to check before your PR can be merged:
pre-commitis installed and set up.