Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Replace time.time with time.perf_counter#1312

Merged
brandonwillard merged 2 commits intoaesara-devs:mainfrom
redbopo:begin_aesara
Nov 25, 2022
Merged

Replace time.time with time.perf_counter#1312
brandonwillard merged 2 commits intoaesara-devs:mainfrom
redbopo:begin_aesara

Conversation

@redbopo
Copy link
Contributor

@redbopo redbopo commented Nov 23, 2022

close #1276

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1312 (2bd953b) into main (14c394d) will increase coverage by 0.05%.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   74.10%   74.15%   +0.05%     
==========================================
  Files         174      174              
  Lines       48673    48706      +33     
  Branches    10373    10372       -1     
==========================================
+ Hits        36067    36119      +52     
+ Misses      10315    10301      -14     
+ Partials     2291     2286       -5     
Impacted Files Coverage Δ
aesara/misc/check_blas.py 0.00% <0.00%> (ø)
aesara/misc/elemwise_time_test.py 0.00% <0.00%> (ø)
aesara/misc/latence_gpu_transfert.py 0.00% <0.00%> (ø)
aesara/compile/function/types.py 79.16% <75.00%> (+0.16%) ⬆️
aesara/link/c/cmodule.py 52.04% <77.77%> (ø)
aesara/tensor/elemwise.py 88.07% <90.54%> (-0.52%) ⬇️
aesara/graph/rewriting/basic.py 65.03% <92.30%> (ø)
aesara/tensor/rewriting/elemwise.py 86.40% <94.73%> (+0.65%) ⬆️
aesara/scalar/basic.py 79.02% <95.16%> (+0.10%) ⬆️
aesara/compile/function/pfunc.py 84.18% <100.00%> (+1.77%) ⬆️
... and 17 more

@rlouf
Copy link
Member

rlouf commented Nov 23, 2022

Thank you for contributing! Should be good after squashing your commits.

@brandonwillard brandonwillard added enhancement New feature or request refactor This issue involves refactoring tooling Relates to developer tools for printing, debugging, and/or manipulating Aesara objects labels Nov 25, 2022
@brandonwillard brandonwillard merged commit 9ec71c8 into aesara-devs:main Nov 25, 2022
@brandonwillard
Copy link
Member

Thanks, @redbopo!

@redbopo redbopo deleted the begin_aesara branch December 5, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request refactor This issue involves refactoring tooling Relates to developer tools for printing, debugging, and/or manipulating Aesara objects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update remaining uses of time.time for profiling

3 participants