This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Refactor SharedVariable and its interfaces#1305
Merged
brandonwillard merged 4 commits intoaesara-devs:mainfrom Nov 21, 2022
Merged
Refactor SharedVariable and its interfaces#1305brandonwillard merged 4 commits intoaesara-devs:mainfrom
SharedVariable and its interfaces#1305brandonwillard merged 4 commits intoaesara-devs:mainfrom
Conversation
`Type` checks are also performed when values are assigned to the property.
brandonwillard
force-pushed
the
refactor-SharedVariable-interface
branch
2 times, most recently
from
69f3304 to
4d578d2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
==========================================
+ Coverage 74.10% 74.12% +0.02%
==========================================
Files 174 174
Lines 48681 48660 -21
Branches 10379 10372 -7
==========================================
- Hits 36074 36071 -3
+ Misses 10313 10297 -16
+ Partials 2294 2292 -2
|
brandonwillard
force-pushed
the
refactor-SharedVariable-interface
branch
from
4d578d2 to
65c6faf
Compare
brandonwillard
changed the title
SharedVariable and its interfaceSharedVariable and its interfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes to
SharedVariableand related machinery:singledispatchto register type constructorsSharedVariable.default_updatea fixed property that defaults toNoneTypechecking and conversion when assigning toSharedVariable.default_updateupdates-related problems much earlier.