New BiLong2ObjectMap implementation#288
Closed
CarlosVara wants to merge 2 commits intoaeron-io:masterfrom
Closed
Conversation
This commit introduces a new BiLong2ObjectMap collection, along with a BiLong2NullableObjectMap companion implementation. These two new maps are derived from the existing BiInt2ObjectMap equivalents that are already present in the collections package. Implementation wise, the BiLong2ObjectMap keeps its keys in a single long[] array, with the 2 key parts stored in adjacent locations. This choice limits the maximum map capacity, but should provide better cache locality for key access.
Author
|
I see one of the new unit tests has a Java17 only call, will try fix and update the pull request |
Contributor
|
@CarlosVara Thanks for raising the PR. Unfortunately, at this time we cannot accept it as we are planning a large overhaul of Agrona collections in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new BiLong2ObjectMap collection, along with a BiLong2NullableObjectMap companion implementation. These two new maps are derived from the existing BiInt2ObjectMap equivalents that are already present in the collections package.
Implementation wise, the BiLong2ObjectMap keeps its keys in a single long[] array, with the 2 key parts stored in adjacent locations. This choice limits the maximum map capacity, but should provide better cache locality for key access.