Skip to content

[ENH] Add CPU-GPU parity test suite for ROCKET#3228

Draft
Adityakushwaha2006 wants to merge 3 commits intoaeon-toolkit:mainfrom
Adityakushwaha2006:tests/rocket-GPU-CPU-parity-comprehensive
Draft

[ENH] Add CPU-GPU parity test suite for ROCKET#3228
Adityakushwaha2006 wants to merge 3 commits intoaeon-toolkit:mainfrom
Adityakushwaha2006:tests/rocket-GPU-CPU-parity-comprehensive

Conversation

@Adityakushwaha2006
Copy link
Contributor

@Adityakushwaha2006 Adityakushwaha2006 commented Jan 8, 2026

Reference Issues/PRs

-Fixes #1248

What does this implement/fix? Explain your changes.

This PR adds a test suite to verify CPU-GPU parity in ROCKET implementations when initialized with the same random seed.

Test Coverage (15 total test variants):

  • Basic parity tests: 8 parametrized tests covering 1, 2, 3, and 8 channels across 50 and 100 timepoints
  • Determinism tests: Verify same seed produces identical results across multiple runs
  • Different seeds tests: 3 parametrized tests ensuring randomness works correctly
  • Edge cases: Minimal data sizes and long series to check boundary conditions and error accumulation
  • API consistency: Verify fit_transform matches fit then transform

All tests verify features match within 1e-4 precision (decimal=4) .

Does your contribution introduce a new dependency? If yes, which one?

None.

Any other comments?

Please note the expected failure of the Cl , until fix is merged into main ( from PR #3227). Will rebase and run to confirm correctness once fix in place.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package labels Jan 8, 2026
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ enhancement ].
I have added the following labels to this PR based on the changes made: [ transformations ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Discord channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as draft February 23, 2026 22:10
@MatthewMiddlehurst
Copy link
Member

Turning to draft until related PR has been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] Test consistency between CPU & GPU version of ROCKET

2 participants