Skip to content

[ENH] Added rocket on gpu#1199

Merged
hadifawaz1999 merged 5 commits intomainfrom
aif/rocket-gpu
Feb 25, 2024
Merged

[ENH] Added rocket on gpu#1199
hadifawaz1999 merged 5 commits intomainfrom
aif/rocket-gpu

Conversation

@hadifawaz1999
Copy link
Member

@hadifawaz1999 hadifawaz1999 commented Feb 17, 2024

Added a tensorflow implementation of ROCKET

Added 2 tests with the transformer

@hadifawaz1999 hadifawaz1999 added the transformations Transformations package label Feb 17, 2024
@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Feb 17, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these two minor comments, everything LTGM !

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some possible very sneaky bugs, it may not be, but It can be a pain to debug if not checked early on.

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential issues with reshape seem to be fixed !
It may a good idea to include a consistency test between CPU & GPU versions (i.e. test that a same-seeded transform output the same results for both versions with an assert_array_almost_equal).
If you feel like this fits into another PR, we can close this one and raise an issue to work on it later.

@hadifawaz1999
Copy link
Member Author

Potential issues with reshape seem to be fixed ! It may a good idea to include a consistency test between CPU & GPU versions (i.e. test that a same-seeded transform output the same results for both versions with an assert_array_almost_equal). If you feel like this fits into another PR, we can close this one and raise an issue to work on it later.

Happy to do both, but maybe putting it as a feature request can be a good first issue for new contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants