Conversation
Thank you for contributing to
|
baraline
left a comment
There was a problem hiding this comment.
Apart from these two minor comments, everything LTGM !
aeon/transformations/collection/convolution_based/rocketGPU/_rocket_gpu.py
Outdated
Show resolved
Hide resolved
aeon/transformations/collection/convolution_based/rocketGPU/_rocket_gpu.py
Show resolved
Hide resolved
baraline
left a comment
There was a problem hiding this comment.
Some possible very sneaky bugs, it may not be, but It can be a pain to debug if not checked early on.
aeon/transformations/collection/convolution_based/rocketGPU/_rocket_gpu.py
Outdated
Show resolved
Hide resolved
aeon/transformations/collection/convolution_based/rocketGPU/_rocket_gpu.py
Outdated
Show resolved
Hide resolved
baraline
left a comment
There was a problem hiding this comment.
Potential issues with reshape seem to be fixed !
It may a good idea to include a consistency test between CPU & GPU versions (i.e. test that a same-seeded transform output the same results for both versions with an assert_array_almost_equal).
If you feel like this fits into another PR, we can close this one and raise an issue to work on it later.
Happy to do both, but maybe putting it as a feature request can be a good first issue for new contributors. |
Added a tensorflow implementation of ROCKET
Added 2 tests with the transformer