Skip to content

Conversation

@mansona
Copy link
Contributor

@mansona mansona commented Feb 26, 2024

This is using https://github.com/mansona/ember-deprecation-error to try to get a better error message to see why the ember-release job is actually failing

@mansona
Copy link
Contributor Author

mansona commented Feb 26, 2024

So it looks like this is failing because of an ember-data deprecation:

The filter method on ember-data's PromiseManyArray is deprecated. await the promise and work with the ManyArray directly.

In the other PR @runspired mentioned that we should probably just throw here if we have a PromiseManyArray #735 (comment)

What do we think about doing that? I'm assuming that would be a breaking change? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant