Skip to content

Validations including a has-many relationship broken when lazily evaluated #686

@BlueRaja

Description

@BlueRaja

Environment

  • Ember Version: 3.16
  • Ember CLI Version: 3.16?
  • Ember CP Validations Version: 4

Steps to Reproduce

outerClass:

buildValidations({
  innerClasses: [
    validator('has-many'),
    validator('inline', {
      dependentKeys: ['model.innerClasses.@each.foo'],
      validate(value) { ... }
    }],
});

innerClass:

buildValidations({
    foo: validator('presence', { presence: true }),
    bar: validator('presence', { presence: true }),
});
  1. While running the app, cause both the inline and has-many validations to fail.
  2. Fix the problem with innerClass so all its validations pass, but don't fix the inline validation

Expected results

Validations fail. outerClass.validations.errors should include 1 error with type === 'inline' and attribute === 'innerClasses'

Actual results

Validations pass

Workarounds

Any one of:

  • Pass { lazy: false } to outerClass's buildValidations call.
  • Reorder the array passed to outerClass's buildValidations call so the has-many validation is last

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions