-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(overlays): cap visualViewport width at clientWidth to handle scrollbar gutter #9275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hasegawa-101
wants to merge
15
commits into
adobe:main
Choose a base branch
from
hasegawa-101:fix/popover-position-scrollbar-gutter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1965848
fix(overlays): cap visualViewport width at clientWidth to handle scro…
hasegawa-101 9f3ca00
Merge branch 'main' into fix/popover-position-scrollbar-gutter
hasegawa-101 0bbdf4a
fix(overlays): delete space
hasegawa-101 b4ca1ca
Merge remote-tracking branch 'origin/fix/popover-position-scrollbar-g…
hasegawa-101 233013e
test(overlays): add visualViewport test case for scrollbar gutter han…
hasegawa-101 619b900
chore(overlays): remove outdated scrollbar gutter handling logic test
hasegawa-101 efc27d7
chore(overlays): comment out outdated visualViewport scrollbar gutter…
hasegawa-101 c47c4f5
Revert "chore(overlays): comment out outdated visualViewport scrollba…
hasegawa-101 535794e
Revert "chore(overlays): remove outdated scrollbar gutter handling lo…
hasegawa-101 f9d5612
fix(overlays): round visualViewport width before comparing to clientW…
hasegawa-101 ffb11b6
Merge branch 'main' into fix/popover-position-scrollbar-gutter
hasegawa-101 f6e4372
fix(overlays): use totalWidth to cap visualViewport width
hasegawa-101 1424e7f
Merge remote-tracking branch 'origin/fix/popover-position-scrollbar-g…
hasegawa-101 3cf80e6
Merge branch 'main' into fix/popover-position-scrollbar-gutter
snowystinger acfc712
Merge branch 'main' into fix/popover-position-scrollbar-gutter
snowystinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might not work either. Chrome will return an incorrect
document.documentElement.clientWidthvalue, which includes the scrollbar width, if the document hasscrollbar-gutter: stable;but no scrollbar is present.See also w3c/csswg-drafts#8099 and https://interop-2022-viewport.netlify.app/scrollbar-gutter/short-stable/