feat(source): intern images on POST check internal on PUT #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
tripodsan
reviewed
Dec 19, 2025
tripodsan
reviewed
Dec 19, 2025
tripodsan
reviewed
Dec 19, 2025
tripodsan
reviewed
Dec 19, 2025
test/source/utils.test.js
Outdated
Comment on lines
139
to
141
| try { | ||
| await getValidHtml(setupContext(), Buffer.from(htmlIn), [], {}); | ||
| assert.fail('Expected an error to be thrown'); |
tripodsan
reviewed
Dec 19, 2025
tripodsan
reviewed
Dec 19, 2025
test/source/utils.test.js
Outdated
| assert.fail('Expected an error to be thrown'); | ||
| } catch (e) { | ||
| assert.equal(e.statusCode, 400); | ||
| assert.equal(e.errorCode, 'AEM_BACKEND_MP4_PARSING_FAILED'); |
tripodsan
reviewed
Dec 19, 2025
tripodsan
requested changes
Dec 19, 2025
Contributor
tripodsan
left a comment
tripodsan
left a comment
There was a problem hiding this comment.
LGTM, tests can be improved.
tripodsan
reviewed
Dec 19, 2025
Co-authored-by: Tobias Bocanegra <[email protected]>
Co-authored-by: Tobias Bocanegra <[email protected]>
Contributor
Author
|
I have rewritten the tests that expect an Error to use One thought I have about this is that if you have the if you accidentally forget the |
tripodsan
reviewed
Jan 5, 2026
tripodsan
approved these changes
Jan 8, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
# [1.26.0](v1.25.1...v1.26.0) (2026-01-08) ### Features * **source:** intern images on POST check internal on PUT ([#74](#74)) ([7b45695](7b45695))
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Contributes to #43