Change font weight of menu items to 400 instead of 200, improves readability

[Mark-Simulacrum]

Fixes #9828.

Things to consider:

• May not be the only place in the UI that this error happens.
• Should the font weight used (400) be put into a LESS variable? If so, how should that variable be named?
  • We already have @font-weight-semibold: 500 and @font-weight-light: 200.

[le717]

FWIW. I'd call the LESS variable (if needed) @font-weight-normal. :)

[nmabhinandan]

This definitely fixes the issue.

[peterflynn]

This should be font-weight: normal which is exactly the same as 400. (See https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#Values)

[peterflynn]

Assigning to @placegraphichere for visual review. (Note: to test this on a non-Linux computer, modify Global.js so that global.brackets.nativeMenus is always set to false). Changing the font-weight seems reasonable to me, but we could also consider changing the color for a similar effect.

[RaymondLim]

Since normal is the default value, I wonder we can just remove this property.

[Mark-Simulacrum]

Fixed: Just removed the line, seems that the setting is not needed; not set to another value anywhere else.

[Mark-Simulacrum]

Should I squash the commits? Feels odd to me to have 3 commits for 1 tiny change.

[ingorichter]

@Mark-Simulacrum Do you still want to squash the commits?
@placegraphichere Did you get a chance to look at this PR?

[Mark-Simulacrum]

@ingorichter Squashed commits, thank you for the reminder!

[ingorichter]

LGTM
Before:

After:

[ingorichter]

@placegraphichere Do you want to have another look at the visual representation or does the change look good to you and I can merge it?

[nmabhinandan]

The problem was primarily in the dark theme running in Ubunut x64 OS. #9828

[le717]

@ingorichter Do you want to get this in 1.2? While I'm not a Linux user, this does fix a visibility issue (which can effect usability), and know it if affected me I'd want this in as soon as possible.

[nmabhinandan]

Yes please.

[ingorichter]

With lighter font

With heavier font