[Close Others] Fix #6019: Contextual Close Others menu entries#6020
Conversation
There was a problem hiding this comment.
In this case, all the commands should be disabled, since you can't close other files.
There was a problem hiding this comment.
They will be disabled too as the selected entry is both first and last (and only) entry.
There was a problem hiding this comment.
Right. Didn't saw that before.
|
Btw: Is there another handler that is called when (before) opening the context menu of the Working Files? |
|
Assigning to @JeffryBooher |
|
Nominating for Sprint 35 |
[Close Others] Fix #6019: Contextual Close Others menu entries
|
Looks good...Merging |
|
I forgot about this PR, but in the meantime I found #5952. I won't say any of these is better or worse, but a difference worth mentioning is using |
This is for #6019, it makes the Close Others context menu entries contextual so that they are dynamically disabled and enabled.