This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Don't prompt before unload while in SpecRunner #13964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13963
Tested manually by:
Opening test runner and navigating between the tabs and confirming that the prompts do not pop up anymore.
Opening dev tools and trying
window.location.pathname = 'https://google.com'to see that the prompt still pops upSigned-off-by: petetnt pete.a.nykanen@gmail.com