Fix tests on M1 Macs #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library/mysql container doesn't support arm64/v8, which caused the tests to not be runnable on M1 Macs. This commit adds two ways to solve this: 1. TestDB now has a SkippedArchs property, which allows certain Docker containers to be tagged to not support certain runtime.GOARCH strings. These cause a skipped test when used. 2. The MySQL test container was switched from libary/mysql to mysql/mysql-server (the one produced directly by the MySQL team), which *does* support arm64/v8, but only on the latest MySQL 8 version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A timezone handling issue and a lack of support for ARM64 architecture in the MySQL container were causing tests to fail when run on M1 Macs. This PR fixes that and prepares a mechanism to skip certain database tests on certain architectures.