REVIEW AND REBASE YOURSELF#4
Open
adlai wants to merge 562 commits into
Open
Conversation
- now supports symbols with escapes (in theory, I'm not sure it's well tested yet - no hacky "parse-symbol" - no hacky (ignore-errors (read ...)) - doesn't recognize () as nil anymore (will be fixed soon enough) - explicitly assume *read-case* is :upcase - some tests are currently broken because of that - perf: this means that "tokens" are not re-parsed every time a pattern is matched against them
because "term" really clashes with the litterature
again, to match the literature's nomenclature better
here and there, I would have the same pattern to extract the package-name from the closest ~(in-package ...)~ form and find the corresponding package, so I extracted that in a method ~current-packge~, but there was already a method using that name. So I renamed the existing ~current-package~ to ~current-package-node~.
- previous-in-package (works) - goto-package-definition (not implemented) - export-symbol-at-point (not implemented) - import-symbols-for-top-level-form (wip)
there's a "current-node" function already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'M NOT ANGRY AT Y'ALL
IT IS MY ISRAELI HABIT
CAPS LOCK ENGLISH KEYS