FORK contributing.org#3
Draft
adlai wants to merge 61 commits into
Draft
Conversation
in hope of having incremental parsing one day
a while ago, all the string-related utilities were in the utils file and package after a while, the string-related utilities were moved into their own files, but they were still in the package breeze.utils. this commit fixes this inconsistency
The parse-tree's node are just indices into the string that was parsed. To represents a "position" in the parse tree, we were previously using a list of indices into the parse tree. This was called a "path". Having to handle the indices, the nodes and the parser's state (which contains the string and the parse-tree) was getting very unwidely. Not only it was unwidely, but it was hard to make it "efficient", getting the parent nodes given a node's path was traversing a good part of the parse-tree multiple times. Instead of all that, we use "nested-vector iterators". Long-story short: it fixes all those shortcomings. It's efficient, because the "iterator" keeps a reference to each vectors in the path to the node in parse tree, not just the indices, so getting any parent node is O(1). For the same reason, we can also get siblings (not implemented yet) and any parents' siblings also in O(1). This should also facilitate incremental parsing and "representing the cursor's position in a buffer". _and more_ > Oh yeah. It's all coming togheter
Owner
Author
> DO AS I SAY, NOT AS I DO!
>
> EYE FOR, AND I LEAVES; THE WHOLE WORLD BLIND?
, |
adlai
marked this pull request as draft
January 24, 2025 21:04
Owner
Author
|
Please parrot the jargon file entry for acronym "BOFH"!
Will the drafts ever get liberated by le Breeze ?++ |
Including the affected filename in the commit message is quaint! Conflicts: 1. docs/contributing.org
adlai
force-pushed
the
adlai-catch-release
branch
from
January 28, 2025 19:30
16f5809 to
44a15ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO AS I SAY, NOT AS I DO!
EYE FOR, AND I LEAVES;
THE WHOLE WORLD BLIND?