Add ability to open menu items in a new tab#1672
Open
cmd05 wants to merge 1 commit intoadityatelange:masterfrom
Open
Add ability to open menu items in a new tab#1672cmd05 wants to merge 1 commit intoadityatelange:masterfrom
cmd05 wants to merge 1 commit intoadityatelange:masterfrom
Conversation
|
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What does this PR change? What problem does it solve?
Add the ability to open specific menu items in a new tab. When an identifier begins with "ext-", it will add a
target="_blank". This is independent of whether the link is an external link, so the user can decide themselves. For example, if I want to make my blog page open in a new tab:Was the change discussed in an issue or in the Discussions before?
Inspired by this PR
This discussion to open all external links in a new tab.
Hugo still has not implemented target parameter for menu items. Issue
PR Checklist