Skip to content

Exports unclutter#884

Merged
adamhathcock merged 2 commits intoadamhathcock:masterfrom
YoshiRulz:exports-unclutter
Dec 19, 2024
Merged

Exports unclutter#884
adamhathcock merged 2 commits intoadamhathcock:masterfrom
YoshiRulz:exports-unclutter

Conversation

@YoshiRulz
Copy link
Contributor

Moves some types from the SharpCompress namespace to SharpCompress.Helpers, so they won't be used accidentally by consumers. (Builds upon #579.) And removes the redundant ReadOnlyCollection<T>.

@adamhathcock
Copy link
Owner

Looks great, thanks!

I changed the param type of the helper, but the stronger constraint
didn't seem to matter in practice
auto-merge was automatically disabled December 19, 2024 12:11

Head branch was pushed to by a user without write access

@YoshiRulz
Copy link
Contributor Author

I think I figured out your autoformatter? Just removed 2 blank lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants