XZ: fix padding issues#300
Merged
adamhathcock merged 4 commits intoadamhathcock:masterfrom Sep 17, 2017
frabar666:fix-padding
Merged
XZ: fix padding issues#300adamhathcock merged 4 commits intoadamhathcock:masterfrom frabar666:fix-padding
adamhathcock merged 4 commits intoadamhathcock:masterfrom
frabar666:fix-padding
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkipPaddinginXZBlockandXZIndexdid not always skip the right number of bytes:This PR fixes both
SkipPaddingmethods, resolves #289 and resolves #296.I added unit tests using two new inline XZ files (an empty one, and one with 2 blocks), in order to test more cases.
Note that this relies on my previous PR #299: I created a new branch on top of the one I used for the previous PR, not sure if that was the right way to go...