Fix ArrayPool corruption from double-disposal in BufferedSubStream#1161
Merged
adamhathcock merged 4 commits intoadam/check-if-seekfrom Jan 26, 2026
Merged
Fix ArrayPool corruption from double-disposal in BufferedSubStream#1161adamhathcock merged 4 commits intoadam/check-if-seekfrom
adamhathcock merged 4 commits intoadam/check-if-seekfrom
Conversation
Co-authored-by: adamhathcock <[email protected]>
Co-authored-by: adamhathcock <[email protected]>
Co-authored-by: adamhathcock <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on seeking check functionality in PR #1160
Fix ArrayPool corruption from double-disposal in BufferedSubStream
Jan 26, 2026
This was referenced Jan 26, 2026
This was referenced Feb 11, 2026
This was referenced Feb 13, 2026
This was referenced Feb 23, 2026
This was referenced Mar 2, 2026
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BufferedSubStream.Disposereturns a rented array toArrayPoolbut lacks guard against multiple disposals. Since_cachewasreadonly, it couldn't be nulled after return, causing the same array to be returned twice on subsequentDisposecalls—corrupting the pool.Changes
_isDisposedflag prevents re-execution of disposal logic_cachenullable: Changed fromreadonly byte[]tobyte[]?to enable nulling after pool returnRefillCachemethods throwObjectDisposedExceptionif called post-disposalCanSeekbefore accessingPositionto avoid exceptions on non-seekable streamsPattern
Follows the same disposal pattern as base class
SharpCompressStream:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.