Fix ArgumentNullException when disposing RarArchive with damaged archives#1025
Merged
adamhathcock merged 2 commits intomasterfrom Nov 19, 2025
Merged
Conversation
Co-authored-by: adamhathcock <[email protected]>
Copilot
AI
changed the title
[WIP] Fix exception when disposing RarArchive
Fix ArgumentNullException when disposing RarArchive with damaged archives
Nov 19, 2025
adamhathcock
approved these changes
Nov 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an ArgumentNullException that occurs when disposing a RarArchive after processing a damaged archive. The issue arises because the window field may be null when Dispose() is called, but the code attempts to return it to the ArrayPool without checking for null first.
- Added defensive null check in
UnpackV1.Unpack.Dispose()before returning the window buffer to the ArrayPool - Aligns with existing null-check patterns used in
RarVM.cs,LzOutWindow.cs, andUnpackV2017
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Nov 28, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
This was referenced Jan 5, 2026
This was referenced Jan 12, 2026
This was referenced Jan 19, 2026
This was referenced Jan 26, 2026
This was referenced Feb 13, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When disposing a
RarArchiveafter processing a damaged archive,ArrayPool<byte>.Shared.Return(window)throwsArgumentNullExceptionbecause thewindowfield may be null.Changes
UnpackV1.Unpack.Dispose()before returning the window buffer to the array poolUnpackV2017implementationOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.