Skip to content

Conversation

@rlcamp
Copy link

@rlcamp rlcamp commented Jul 12, 2024

without the suffix, the value is erroneously being shifted twice, which happens to be harmless in these particular instances because the shift is by zero

without the suffix, the value is erroneously being shifted twice, which happens to be harmless in these particular instances because the shift is by zero
@hathach hathach requested a review from Copilot September 8, 2025 16:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where clock source constants were missing the _Val suffix when passed to the GCLK_GENCTRL_SRC() macro, causing double shifting of values. The fix ensures proper clock configuration by using the correct constant values.

  • Adds _Val suffix to clock source constants in macro calls
  • Fixes potential double-shifting issue in clock generator configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, thank you

@hathach hathach merged commit d8f4bf4 into adafruit:master Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants