add compatibility for AudioOut API changes in CP 3.x#10
Merged
Conversation
- added `sys` import since that is what is used for version detection
- added updated sample generation for 3.x AudioOut.play()
- .play(loop=False) (2.x) -> .play(sample, *, loop=False) (3.)
- updated audioio.AudioOut() constructor to be 3.x compatiible
Contributor
Author
|
Verified to work on both CP 3.x/libs and CP 2.x/libs on CPX 😄 |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 12, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.2.1 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#10 from idcrook/fix_for_CP_RTTTL_issue8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for fix of #8
tested on a CPX
added
sysimport since that is what is used for version detectionadded updated sample generation for 3.x AudioOut.play()
updated audioio.AudioOut() constructor to be 3.x compatiible